[rust] Add license and notice links to Selenium Manager help - #17986
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Expose the Selenium LICENSE and NOTICE URLs in --help and cover the output with a focused regression test. Related to SeleniumHQ#16113
c9e5a0e to
8d573c2
Compare
diemol
left a comment
There was a problem hiding this comment.
We'd prefer a different approach here: embed LICENSE/NOTICE into the binary via include_str! + compile_data, and add a --license flag to print them in full. A link to
blob/trunk/LICENSE needs network access and isn't pinned to this binary's version, so it doesn't fully satisfy #16113.
Add --license to print the full embedded LICENSE and NOTICE texts without requiring network access. Related to SeleniumHQ#16113
Updated to embed both files at build time with |
Code Review by Qodo
1.
|
Include package-local LICENSE and NOTICE copies for Cargo archives and verify they stay synchronized with the canonical repository files. Related to SeleniumHQ#16113
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Code review by qodo was updated up to the latest commit 0dfd73c |
🔗 Related Issues
Related to #16113
💥 What does this PR do?
Embeds the full LICENSE and NOTICE texts in Selenium Manager and adds a
--licenseflag to print them without network access.🔧 Implementation Notes
Uses package-local LICENSE and NOTICE copies with Rust's
include_str!and Bazelcompile_data, so Cargo archives and each binary carry the legal texts. A repository-only test keeps the package copies synchronized with the canonical root files, and a focused regression test verifies the complete output.🤖 AI assistance
💡 Additional Considerations
This covers Selenium Manager only. Other bindings and components remain tracked by #16113.
🔄 Types of changes